timw4mail
/
HummingBirdAnimeClient
1
1
Fork 1
Code Issues 5 Pull Requests Projects 1 Releases Wiki Activity

Partially fix broken tests
timw4mail/HummingBirdAnimeClient/pipeline/head There was a failure building this commit Details

This commit is contained in:
Timothy Warren 2021-12-02 17:08:11 -05:00
parent f3d347f249
commit c012b049e1
4 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/AnimeClient/Types/AbstractType.php
View File

@ -37,7 +37,7 @@ abstract class AbstractType implements ArrayAccess, Countable {
* @param array $data
* @return array|null
*/
final public static function check($data = []): ?array
final public static function check(array $data = []): ?array
{
$currentClass = static::class;
@ -199,7 +199,7 @@ abstract class AbstractType implements ArrayAccess, Countable {
*/
final public function count(): int
{
$keys = array_keys((array)$this->toArray());
$keys = array_keys($this->toArray());
return count($keys);
}
@ -224,7 +224,7 @@ abstract class AbstractType implements ArrayAccess, Countable {
*/
final public function isEmpty(): bool
{
$self = (array)$this->toArray();
$self = $this->toArray();
foreach ($self as $value)
{
if ( ! empty($value))

2
src/AnimeClient/Types/Anime.php
View File

@ -36,8 +36,6 @@ class Anime extends AbstractType {
public string $id = '';
public array $included = [];
public ?string $show_type;
public ?string $slug;

2
src/AnimeClient/Types/Character.php
View File

@ -26,8 +26,6 @@ final class Character extends AbstractType {
public string $id;
public array $included = [];
public ?Media $media;
public ?string $name;

1
tests/AnimeClient/API/Kitsu/Transformer/__snapshots__/AnimeListTransformerTest__testUntransform with data set 2__1.yml
View File

@ -6,6 +6,7 @@ data:
notes: ''
private: true
progress: 12
ratingTwenty: null
reconsumeCount: 0
reconsuming: true
status: current