From c012b049e16a383c097a9188ae4866464ce81e2c Mon Sep 17 00:00:00 2001 From: "Timothy J. Warren" Date: Thu, 2 Dec 2021 17:08:11 -0500 Subject: [PATCH] Partially fix broken tests --- src/AnimeClient/Types/AbstractType.php | 6 +++--- src/AnimeClient/Types/Anime.php | 2 -- src/AnimeClient/Types/Character.php | 2 -- ...tTransformerTest__testUntransform with data set 2__1.yml | 1 + 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/AnimeClient/Types/AbstractType.php b/src/AnimeClient/Types/AbstractType.php index 1dc3b593..bbd0dd7c 100644 --- a/src/AnimeClient/Types/AbstractType.php +++ b/src/AnimeClient/Types/AbstractType.php @@ -37,7 +37,7 @@ abstract class AbstractType implements ArrayAccess, Countable { * @param array $data * @return array|null */ - final public static function check($data = []): ?array + final public static function check(array $data = []): ?array { $currentClass = static::class; @@ -199,7 +199,7 @@ abstract class AbstractType implements ArrayAccess, Countable { */ final public function count(): int { - $keys = array_keys((array)$this->toArray()); + $keys = array_keys($this->toArray()); return count($keys); } @@ -224,7 +224,7 @@ abstract class AbstractType implements ArrayAccess, Countable { */ final public function isEmpty(): bool { - $self = (array)$this->toArray(); + $self = $this->toArray(); foreach ($self as $value) { if ( ! empty($value)) diff --git a/src/AnimeClient/Types/Anime.php b/src/AnimeClient/Types/Anime.php index 3dc52c48..e201f8a5 100644 --- a/src/AnimeClient/Types/Anime.php +++ b/src/AnimeClient/Types/Anime.php @@ -36,8 +36,6 @@ class Anime extends AbstractType { public string $id = ''; - public array $included = []; - public ?string $show_type; public ?string $slug; diff --git a/src/AnimeClient/Types/Character.php b/src/AnimeClient/Types/Character.php index 252d3823..d55f514a 100644 --- a/src/AnimeClient/Types/Character.php +++ b/src/AnimeClient/Types/Character.php @@ -26,8 +26,6 @@ final class Character extends AbstractType { public string $id; - public array $included = []; - public ?Media $media; public ?string $name; diff --git a/tests/AnimeClient/API/Kitsu/Transformer/__snapshots__/AnimeListTransformerTest__testUntransform with data set 2__1.yml b/tests/AnimeClient/API/Kitsu/Transformer/__snapshots__/AnimeListTransformerTest__testUntransform with data set 2__1.yml index 98e0c061..9547c37b 100644 --- a/tests/AnimeClient/API/Kitsu/Transformer/__snapshots__/AnimeListTransformerTest__testUntransform with data set 2__1.yml +++ b/tests/AnimeClient/API/Kitsu/Transformer/__snapshots__/AnimeListTransformerTest__testUntransform with data set 2__1.yml @@ -6,6 +6,7 @@ data: notes: '' private: true progress: 12 + ratingTwenty: null reconsumeCount: 0 reconsuming: true status: current