timw4mail/HummingBirdAnimeClient
1
1
Fork 1
Code Issues 5 Pull Requests Projects 1 Releases Wiki Activity

Version 5.1 - All the GraphQL #32

Closed
timw4mail wants to merge 1160 commits from develop into master
pull from: develop
merge into: timw4mail:master
Conversation 0 Commits 1160 Files Changed 547 +4 -12
2 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit dc20d8de7c - Show all commits

13
src/AnimeClient/API/Kitsu.php
View File

@ -206,7 +206,7 @@ final class Kitsu {
$raw = array_unique([ $raw = array_unique([
$data['canonicalTitle'], $data['canonicalTitle'],
...array_values($data['titles']), ...array_values($data['titles']),
...array_values($data['abbreviatedTitles']), ...array_values($data['abbreviatedTitles'] ?? []),
]); ]);
return array_diff($raw,[$data['canonicalTitle']]); return array_diff($raw,[$data['canonicalTitle']]);
@ -234,17 +234,6 @@ final class Kitsu {
} }
} }
if (array_key_exists('abbreviatedTitles', $data))
{
foreach ($data['abbreviatedTitles'] as $alternateTitle)
{
if (self::titleIsUnique($alternateTitle, $valid))
{
$valid[] = $alternateTitle;
}
}
}
return $valid; return $valid;
} }

3
tests/AnimeClient/API/Kitsu/Transformer/__snapshots__/AnimeTransformerTest__testTransform__1.yml
View File

@ -29,5 +29,8 @@ titles:
- 'Attack on Titan' - 'Attack on Titan'
- 'Shingeki no Kyojin' - 'Shingeki no Kyojin'
- 進撃の巨人 - 進撃の巨人
titles_more:
2: 'Shingeki no Kyojin'
3: 進撃の巨人
trailer_id: n4Nj6Y_SNYI trailer_id: n4Nj6Y_SNYI
url: 'https://kitsu.io/anime/attack-on-titan' url: 'https://kitsu.io/anime/attack-on-titan'