timw4mail
/
HummingBirdAnimeClient
1
1
Fork 1
Code Issues 5 Pull Requests Projects 1 Releases Wiki Activity

Don't cache API calls that return errors #26

New Issue
Closed
opened 2020-05-06 09:24:14 -04:00 by timw4mail · 1 comment
timw4mail commented 2020-05-06 09:24:14 -04:00
Owner
Copy Link

Currently, cached API calls just save the result of the API call regardless of whether the API call succeeded.

Check the result of the API call before caching.

Currently, cached API calls just save the result of the API call regardless of whether the API call succeeded. Check the result of the API call before caching.
timw4mail added the
Bug
 label 2020-05-06 09:25:10 -04:00
timw4mail commented 2020-10-16 16:29:37 -04:00
Author
Owner
Copy Link

This doesn't seem to be an issue after some research.

This doesn't seem to be an issue after some research.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
develop
v5.2.0
v5.1.0
v4.2.0
v4.1.0
v4.0.0
v3.0
v2.2.1
v2.2
v2.1
v2
Labels
Clear labels   
Bug

   
Feature Request

   
Other

   
Planned Feature

   
Planning
No Label
Bug
Feature Request
Other
Planned Feature
Planning
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: timw4mail/HummingBirdAnimeClient#26
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?