From dbbea163d10b13c984b3ab2d7407bbfe72c78d95 Mon Sep 17 00:00:00 2001 From: "Timothy J. Warren" Date: Tue, 6 Oct 2015 10:44:33 -0400 Subject: [PATCH] Scrutinizer fixes --- index.php | 1 - src/Aviat/AnimeClient/Controller.php | 3 +++ src/Aviat/AnimeClient/Controller/Manga.php | 2 -- src/Aviat/Ion/Friend.php | 2 ++ 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/index.php b/index.php index a862b945..26bff907 100644 --- a/index.php +++ b/index.php @@ -2,7 +2,6 @@ /** * Here begins everything! */ -session_start(); // Work around the silly timezone error $timezone = ini_get('date.timezone'); diff --git a/src/Aviat/AnimeClient/Controller.php b/src/Aviat/AnimeClient/Controller.php index c7e16488..340b5a77 100644 --- a/src/Aviat/AnimeClient/Controller.php +++ b/src/Aviat/AnimeClient/Controller.php @@ -11,6 +11,9 @@ use \Aviat\Ion\View\JsonView; /** * Controller base, defines output methods + * + * @property Response object $response + * @property Config object $config */ class Controller { diff --git a/src/Aviat/AnimeClient/Controller/Manga.php b/src/Aviat/AnimeClient/Controller/Manga.php index 458de1ed..6e86ada3 100644 --- a/src/Aviat/AnimeClient/Controller/Manga.php +++ b/src/Aviat/AnimeClient/Controller/Manga.php @@ -102,8 +102,6 @@ class Manga extends Controller { ? [$map[$status] => $this->model->get_list($map[$status])] : $this->model->get_all_lists(); - //throw new \ErrorException("Data :" . print_r($data, TRUE)); - $this->outputHTML('manga/' . $view_map[$view], [ 'title' => $title, 'sections' => $data, diff --git a/src/Aviat/Ion/Friend.php b/src/Aviat/Ion/Friend.php index 20c49274..dbd5ae2f 100644 --- a/src/Aviat/Ion/Friend.php +++ b/src/Aviat/Ion/Friend.php @@ -99,6 +99,8 @@ class Friend { $property->setAccessible(TRUE); return $property; } + // Return NULL on any exception, so no further logic needed + // in the catch block catch (\Exception $e) {} return NULL;