timw4mail/HummingBirdAnimeClient
1
1
Fork 1
Code Issues 5 Pull Requests Projects 1 Releases Wiki Activity

Cache API errors at the dispatcher level, so a more appropriate error page can be displayed

Browse Source
This commit is contained in:
Timothy Warren 2017-01-13 16:52:12 -05:00
parent 29d8207c63
commit 68bee55f6a
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/Dispatcher.php
View File

@ -18,6 +18,7 @@ namespace Aviat\AnimeClient;
use Aviat\Ion\Di\ContainerInterface; use Aviat\Ion\Di\ContainerInterface;
use Aviat\Ion\Friend; use Aviat\Ion\Friend;
use GuzzleHttp\Exception\ServerException;
/** /**
* Basic routing/ dispatch * Basic routing/ dispatch
@ -128,9 +129,23 @@ class Dispatcher extends RoutingBase {
$actionMethod = $error_route['action_method']; $actionMethod = $error_route['action_method'];
$params = $error_route['params']; $params = $error_route['params'];
} }
// Actually instantiate the controller // Try to catch API errors in a presentable fashion
$this->call($controllerName, $actionMethod, $params); try
{
// Actually instantiate the controller
$this->call($controllerName, $actionMethod, $params);
}
catch (ServerException $e)
{
$response = $e->getResponse();
$this->call(AnimeClient::DEFAULT_CONTROLLER, AnimeClient::ERROR_MESSAGE_METHOD, [
$response->getStatusCode(),
'API Error',
'There was a problem getting data from an external source.',
(string) $response->getBody()
]);
}
} }
/** /**