timw4mail/HummingBirdAnimeClient
1
1
Fork 1
Code Issues 5 Pull Requests Projects 1 Releases Wiki Activity

Make sure rating parameter sent to Kitsu is greater than 0

Browse Source
This commit is contained in:
Timothy Warren 2017-04-06 14:53:38 -04:00
parent b444648a3d
commit 5357bfb122
3 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/API/Kitsu/Transformer/AnimeListTransformer.php
View File

@ -123,7 +123,7 @@ class AnimeListTransformer extends AbstractTransformer {
] ]
]; ];
if (is_numeric($item['user_rating'])) if (is_numeric($item['user_rating']) && $item['user_rating'] > 0)
{ {
$untransformed['data']['rating'] = $item['user_rating'] / 2; $untransformed['data']['rating'] = $item['user_rating'] / 2;
} }

13
tests/API/Kitsu/Transformer/AnimeListTransformerTest.php
View File

@ -68,6 +68,19 @@ class AnimeListTransformerTest extends AnimeClientTestCase {
'private' => 'On', 'private' => 'On',
'rewatching' => 'On' 'rewatching' => 'On'
] ]
], [
'input' => [
'id' => 14047983,
'mal_id' => '12347',
'watching_status' => 'current',
'user_rating' => 0,
'episodes_watched' => 12,
'rewatched' => 0,
'notes' => '',
'edit' => 'true',
'private' => 'On',
'rewatching' => 'On'
]
]]; ]];
} }

13
tests/API/Kitsu/Transformer/__snapshots__/AnimeListTransformerTest__testUntransform with data set #2__1.php Normal file
View File

@ -0,0 +1,13 @@
<?php return array (
'id' => 14047983,
'mal_id' => '12347',
'data' =>
array (
'status' => 'current',
'reconsuming' => true,
'reconsumeCount' => 0,
'notes' => '',
'progress' => 12,
'private' => true,
),
);