timw4mail/HummingBirdAnimeClient
1
1
Fork 1
Code Issues 5 Pull Requests Projects 1 Releases Wiki Activity

Bug fixes
All checks were successful
timw4mail/HummingBirdAnimeClient/pipeline/head This commit looks good
Details

Browse Source
This commit is contained in:
Timothy Warren 2020-05-11 09:17:11 -04:00
parent cacf19781d
commit 332ff72360
3 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/AnimeClient/API/Kitsu.php
View File

@ -225,13 +225,16 @@ final class Kitsu {
// The 'canonical' title is always returned // The 'canonical' title is always returned
$valid = [$data['canonicalTitle']]; $valid = [$data['canonicalTitle']];
if (array_key_exists('titles', $data)) foreach (['titles', 'abbreviatedTitles'] as $key)
{ {
foreach($data['titles'] as $alternateTitle) if (array_key_exists($key, $data) && is_array($data[$key]))
{ {
if (self::titleIsUnique($alternateTitle, $valid)) foreach($data[$key] as $alternateTitle)
{ {
$valid[] = $alternateTitle; if (self::titleIsUnique($alternateTitle, $valid))
{
$valid[] = $alternateTitle;
}
} }
} }
} }

4
src/AnimeClient/API/Kitsu/Transformer/MangaTransformer.php
View File

@ -98,12 +98,12 @@ final class MangaTransformer extends AbstractTransformer {
if ( ! empty($characters['main'])) if ( ! empty($characters['main']))
{ {
uasort($characters['main'], fn ($a, $b) => $a['name'] <=> $b['anime']); uasort($characters['main'], fn ($a, $b) => $a['name'] <=> $b['name']);
} }
if ( ! empty($characters['supporting'])) if ( ! empty($characters['supporting']))
{ {
uasort($characters['supporting'], fn ($a, $b) => $a['name'] <=> $b['anime']); uasort($characters['supporting'], fn ($a, $b) => $a['name'] <=> $b['name']);
} }
ksort($characters); ksort($characters);

4
src/AnimeClient/API/ParallelAPIRequest.php
View File

@ -103,9 +103,7 @@ final class ParallelAPIRequest {
foreach ($this->requests as $key => $url) foreach ($this->requests as $key => $url)
{ {
$promises[$key] = call(static function () use ($client, $url) { $promises[$key] = call(fn () => yield $client->request($url));
return yield $client->request($url);
});
} }
return wait(all($promises)); return wait(all($promises));