aviat/kis-js
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Lots of IE 8 fixes

Browse Source
This commit is contained in:
Timothy Warren 2011-07-05 19:19:32 -04:00
parent 1316ac4b32
commit e83c33e65e
1 changed files with 33 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
kis.js
View File

@ -17,14 +17,6 @@
{ {
return; return;
} }
//Define console.log dummy function if it doesn't exist
if(typeof window.console === "undefined")
{
window.console = {
log: function(){}
};
}
var $_, $; var $_, $;
@ -54,7 +46,7 @@
else else
{ {
x = document.querySelectorAll(a); x = document.querySelectorAll(a);
} }
return (x.length === 1) ? x[0] : x; return (x.length === 1) ? x[0] : x;
}; };
@ -93,7 +85,7 @@
callback = function (){}; callback = function (){};
} }
var request = (typeof window.XMLHttpRequest === "function") var request = (typeof window.XMLHttpRequest !== "undefined")
? new XMLHttpRequest() ? new XMLHttpRequest()
: false; : false;
@ -309,7 +301,7 @@
// Define the proper attach and remove functions // Define the proper attach and remove functions
// based on browser support // based on browser support
if(support.addEventListener) if(support.addEventListener === true)
{ {
attach = function (sel, event, callback) attach = function (sel, event, callback)
{ {
@ -326,7 +318,7 @@
} }
}; };
} }
else if(support.attachEvent) else if(typeof document.attachEvent !== "undefined")
{ {
attach = function (sel, event, callback) attach = function (sel, event, callback)
{ {
@ -336,7 +328,7 @@
callback.apply(sel, arguments); callback.apply(sel, arguments);
} }
if (typeof sel.attachEvent === "function") if (typeof sel.attachEvent !== "undefined")
{ {
remove(sel, event, callback); // Make sure we don't have duplicate listeners remove(sel, event, callback); // Make sure we don't have duplicate listeners
@ -351,10 +343,14 @@
listener: listener listener: listener
}); });
} }
else
{
console.log("Failed to attach event:"+event);
}
}; };
remove = function (sel, event, callback) remove = function (sel, event, callback)
{ {
if(typeof typeof sel.detachEvent === "function") if(typeof sel.detachEvent !== "undefined")
{ {
var expando = sel[kis_expando]; var expando = sel[kis_expando];
if (expando && expando.listeners if (expando && expando.listeners
@ -406,16 +402,21 @@
return; return;
} }
else
{
event = event[0];
}
//Check for multiple DOM objects //Check for multiple DOM objects
if (sel.length > 1) if (sel.length > 1)
{ {
var selx = (sel.item(i)) ? sel.item(i) : sel[i];
len = sel.length; len = sel.length;
for (i = 0; i < len; i++) for (i = 0; i < len; i++)
{ {
(add === true) (add === true)
? attach(sel[i], event, callback) ? attach(selx, event, callback)
: remove(sel[i], event, callback); : remove(selx, event, callback);
} }
} }
else else
@ -451,7 +452,17 @@
//Private function for getting/setting attributes //Private function for getting/setting attributes
function _attr(sel, name, value) function _attr(sel, name, value)
{ {
var oldVal, doAttr; var oldVal, doAttr, i;
if(sel.length > 1)
{
var len = sel.length;
for(i=0;i<len;i++)
{
_attr(sel[i], name, value);
}
}
//Get the value of the attribute, if it exists //Get the value of the attribute, if it exists
if (typeof sel.hasAttribute !== "undefined") if (typeof sel.hasAttribute !== "undefined")
@ -478,6 +489,7 @@
//Well, I guess that attribute doesn't exist //Well, I guess that attribute doesn't exist
if (typeof oldVal === "undefined" && (typeof value === "undefined" || value === null)) if (typeof oldVal === "undefined" && (typeof value === "undefined" || value === null))
{ {
console.log(value);
console.log(sel); console.log(sel);
console.log("Element does not have the selected attribute"); console.log("Element does not have the selected attribute");
return; return;
@ -528,7 +540,7 @@
else //Or the hard way else //Or the hard way
{ {
//No class attribute? Set an empty string //No class attribute? Set an empty string
ec = _attr(sel, "class"); ec = sel.className;//_attr(sel, "class");
ec = (typeof ec === "string") ? ec : ''; ec = (typeof ec === "string") ? ec : '';
//Convert class attribute string into array //Convert class attribute string into array
@ -612,9 +624,11 @@
return callback(sel); return callback(sel);
} }
var selx;
for (var x = 0; x < sel.length; x++) for (var x = 0; x < sel.length; x++)
{ {
callback(sel[x]); selx = (sel.item(x)) ? sel.item(x) : sel[x];
callback(selx);
} }
} }
}, },