From 235f93bdc46f93ba45748013267ae47b4eade35c Mon Sep 17 00:00:00 2001 From: "Timothy J. Warren" Date: Tue, 1 Apr 2014 14:06:49 -0400 Subject: [PATCH] Simplify a method in the connection manager --- classes/connection_manager.php | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/classes/connection_manager.php b/classes/connection_manager.php index d1cb45c..b4c09b8 100644 --- a/classes/connection_manager.php +++ b/classes/connection_manager.php @@ -212,15 +212,12 @@ final class Connection_Manager { */ private function create_dsn($dbtype, $params) { - // Add the driver type to the dsn - $dsn = ($dbtype !== 'firebird' && $dbtype !== 'sqlite') - ? strtolower($dbtype).':' - : ''; - if ($dbtype === 'firebird') $dsn = "{$params->host}:{$params->file}"; elseif ($dbtype === 'sqlite') $dsn = $params->file; else { + $dsn = strtolower($dbtype) . ':'; + if ( ! empty($params->database)) { $dsn .= "dbname={$params->database}";