From c4c0444e8787cd8a1b893b0a663a09763dce48e1 Mon Sep 17 00:00:00 2001
From: Timothy Warren <tim@timshomepage.net>
Date: Tue, 21 Feb 2012 12:55:25 -0500
Subject: [PATCH] Minor Firebird fixes, more visibility declarations

---
 src/databases/firebird.php   | 6 +++---
 src/databases/odbc_manip.php | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/databases/firebird.php b/src/databases/firebird.php
index 3ef38be..8c5b12a 100644
--- a/src/databases/firebird.php
+++ b/src/databases/firebird.php
@@ -17,7 +17,7 @@
  * 
  * PDO-firebird isn't stable, so this is a wrapper of the ibase_ public functions.
  */
-class firebird {
+class firebird extends DB_PDO {
 
 	protected $conn, $statement, $trans;
 	private $esc_char = "''";
@@ -217,11 +217,11 @@ SQL;
 	/**
 	 * Start a database transaction
 	 * 
-	 * @return resource
+	 * @return bool
 	 */
 	public function beginTransaction()
 	{
-		if($this->trans = ibase_trans($this->conn) !== null)
+		if(($this->trans = ibase_trans($this->conn)) !== NULL)
 		{
 			return TRUE;
 		}
diff --git a/src/databases/odbc_manip.php b/src/databases/odbc_manip.php
index 720bb3e..e70c6fd 100644
--- a/src/databases/odbc_manip.php
+++ b/src/databases/odbc_manip.php
@@ -19,13 +19,13 @@
   */
 class ODBC_manip extends db_manip {
 
-	function create_table($name, $columns, $constraints=array(), $indexes=array())
+	public function create_table($name, $columns, $constraints=array(), $indexes=array())
 	{
 		//ODBC can't know how to create a table
 		return FALSE;
 	}
 
-	function delete_table($name)
+	public function delete_table($name)
 	{
 		return "DROP TABLE {$name}";
 	}