Do you wish to register an account?
Browse Source

Attempt to fix MySQL transaction test

master
Timothy Warren 2 months ago
parent
commit
d69655be02
2 changed files with 14 additions and 3 deletions
  1. +0
    -3
      tests/ConnectionManagerTest.php
  2. +14
    -0
      tests/Drivers/MySQL/MySQLDriverTest.php

+ 0
- 3
tests/ConnectionManagerTest.php View File

@ -91,8 +91,6 @@ class ConnectionManagerTest extends TestCase {
};
$conn = self::$instance->connect($params);
$this->assertInstanceOf(QueryBuilderInterface::class, $conn);
// Check that the connection just made is returned from the get_connection method
$this->assertEqual($conn, self::$instance->getConnection());
@ -111,7 +109,6 @@ class ConnectionManagerTest extends TestCase {
];
$conn = self::$instance->connect($params);
$this->assertInstanceOf(QueryBuilderInterface::class, $conn);
$this->assertEqual($conn, self::$instance->getConnection('conn_manager'));
}


+ 14
- 0
tests/Drivers/MySQL/MySQLDriverTest.php View File

@ -154,6 +154,13 @@ SQL;
public function testCommitTransaction(): void
{
// Make sure we aren't already in a transaction
if (self::$db->inTransaction())
{
self::$db->commit();
}
$this->assertFalse(self::$db->inTransaction());
$this->assertTrue(self::$db->beginTransaction());
$sql = 'INSERT INTO `create_test` (`id`, `key`, `val`) VALUES (10, 12, 14)';
@ -165,6 +172,13 @@ SQL;
public function testRollbackTransaction(): void
{
// Make sure we aren't already in a transaction
if (self::$db->inTransaction())
{
self::$db->commit();
}
$this->assertFalse(self::$db->inTransaction());
$this->assertTrue(self::$db->beginTransaction());
$sql = 'INSERT INTO `create_test` (`id`, `key`, `val`) VALUES (182, 96, 43)';


Loading…
Cancel
Save